Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial PoC for checking return values #846

Merged
merged 28 commits into from
Apr 15, 2024
Merged

Conversation

fwendland
Copy link
Collaborator

In some cases API calls generate values from configurations that are not part of the source code (such as configuration files). To ensure that subsequent code adheres to set requirements, it's necessary to code some kind of check.

This PoC evaluates these checks to ensure requirements are met and to reduce false-positives.

seelchen and others added 23 commits April 11, 2024 09:22
@fwendland fwendland self-assigned this Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 54.38596% with 208 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (2655ff3) to head (9ec8694).
Report is 1 commits behind head on main.

❗ Current head 9ec8694 differs from pull request most recent head 4ebf323. Consider uploading reports for the commit 4ebf323 to get more accurate results

Files Patch % Lines
...ckends/cpg/coko/evaluators/CpgWheneverEvaluator.kt 47.66% 87 Missing and 14 partials ⚠️
...sec/codyze/backends/cpg/coko/dsl/DataItemCpgDsl.kt 10.52% 15 Missing and 2 partials ⚠️
.../specificationLanguages/coko/core/dsl/Condition.kt 41.66% 14 Missing ⚠️
...ificationLanguages/coko/core/modelling/DataItem.kt 44.00% 11 Missing and 3 partials ⚠️
...nguages/coko/core/modelling/ConditionComponents.kt 60.00% 12 Missing ⚠️
...cificationLanguages/coko/core/WheneverEvaluator.kt 42.10% 11 Missing ⚠️
.../codyze/backends/cpg/coko/dsl/ImplementationDsl.kt 47.36% 7 Missing and 3 partials ⚠️
...ecificationLanguages/coko/dsl/host/CokoExecutor.kt 64.00% 2 Missing and 7 partials ⚠️
...ionLanguages/coko/core/dsl/TransformationResult.kt 33.33% 8 Missing ⚠️
...cationLanguages/coko/dsl/host/ConceptTranslator.kt 92.85% 1 Missing and 4 partials ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #846      +/-   ##
============================================
- Coverage     82.39%   75.52%   -6.87%     
- Complexity      179      223      +44     
============================================
  Files            49       58       +9     
  Lines          1363     1802     +439     
  Branches        184      246      +62     
============================================
+ Hits           1123     1361     +238     
- Misses          157      329     +172     
- Partials         83      112      +29     
Flag Coverage Δ
unittests 75.52% <54.38%> (-6.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland
Copy link
Collaborator Author

We'll merge it as an experimental feature!

@fwendland fwendland merged commit ec8c63b into main Apr 15, 2024
3 of 4 checks passed
@fwendland fwendland deleted the sl/concept-translator branch April 15, 2024 09:45
fwendland added a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Selina Lin <[email protected]>
Co-authored-by: Robert Haimerl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants